move to the new DS #522
Merged
move to the new DS #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 731eb10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Failed to generate code suggestions for PR |
…-settings-layout # Conflicts: # yarn.lock
Improve settings layout
* fixed centering of EmptyStateEditor (#1612) * added changeset
SorsOps
reviewed
Dec 5, 2024
| borderRadius: '$medium', | ||
| background: '$gray2' | ||
| <div | ||
| style={{ |
| children, | ||
| className, | ||
| }: { | ||
| children: React.ReactNode; |
There was a problem hiding this comment.
These should be based on React.DivElements
| @@ -34,21 +34,10 @@ export function ColorPickerPopover({ | |||
| <InputPopover | |||
| defaultOpen={defaultOpen} | |||
| trigger={ | |||
| <Box | |||
| <Button | |||
| as="button" | |||
There was a problem hiding this comment.
Probably don't need as button anymore
| <Stack | ||
| align="center" | ||
| gap={2} | ||
| style={{ color: 'var(--color-neutral-canvas-default-fg-subtle)' }} |
| background: '$bgCanvas', | ||
| padding: '$3', | ||
| borderRadius: '$medium', | ||
| style={{ |
| @@ -166,7 +165,7 @@ export const CustomRender0: React.FC<{ | |||
| }> = ({ action, index }) => { | |||
| return ( | |||
| <Stack | |||
| css={{ | |||
| style={{ | |||
There was a problem hiding this comment.
We can clean up all of these to be classes too
SorsOps
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing Box and stiches
cleaning up and preparing for the new ds